Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release process for staging images #460

Merged
merged 3 commits into from
Sep 10, 2019

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Sep 4, 2019

Blocked by: kubernetes/k8s.io#351

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 4, 2019
@sbueringer
Copy link
Member Author

@jichenjc That's the one I mentioned in this PR: #458

@sbueringer
Copy link
Member Author

sbueringer commented Sep 4, 2019

Ongoing discussion here:

Possibly GCB will be used instead of Github Actions

I'll keep this PR here open until a release process can be implemented (similar to the one of other providers)

I'll open a separate PR to finalize some stuff to push images to staging bucket manually & get clusterctl working with latest versions of CABPK & CAPI

@sbueringer
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2019
@jichenjc
Copy link
Contributor

jichenjc commented Sep 5, 2019

I can't open this
https://docs.google.com/document/d/1E2GOa3b9OgrI0PS2R-UVWDRi-m_Vd3va7cOkDQHDm5w/edit# and requesting access now

my guess is someone has to help us (k8s infra? ) to build the images automatically when each PR get merged, so that we can get that image from gcr ? @sbueringer

@sbueringer
Copy link
Member Author

sbueringer commented Sep 5, 2019

I can't open this
https://docs.google.com/document/d/1E2GOa3b9OgrI0PS2R-UVWDRi-m_Vd3va7cOkDQHDm5w/edit# and requesting access now

my guess is someone has to help us (k8s infra? ) to build the images automatically when each PR get merged, so that we can get that image from gcr ? @sbueringer

The current status is I can push the images for now manually (you can also, because you're in the Google group). CAPA is currently doing a POC how the final automated process will look like and I'm in contact with them. I would wait for the results and then implement it like they did.

To push the staging images manually you have to do the following steps:

For now I would only do this manually after master merges. I think the rough idea right now is to publish to the staging bucket whenever a PR is merged to master (under the latest tag). And when a release is done the staging image can be promoted to the production bucket. But the details are getting figured out right now

P.S. First image already pushed for all architectures: https://console.cloud.google.com/gcr/images/k8s-staging-capi-openstack?project=k8s-staging-capi-openstack&folder&organizationId=758905017065

docker pull gcr.io/k8s-staging-capi-kubeadm/cluster-api-kubeadm-controller:latest 

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2019
@sbueringer sbueringer mentioned this pull request Sep 7, 2019
2 tasks
…bug, also copy addons to examples output folder, Re-sync makefile
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2019
@sbueringer
Copy link
Member Author

Added the following related PRs:

@sbueringer
Copy link
Member Author

@jichenjc @chrigl Can I get a lgtm for this PR (for the first try :)). Like mentioned here: kubernetes/test-infra#14246 (comment) this PR is a prereq for the prow job

@sbueringer sbueringer changed the title [WIP] add release process for staging Add release process for staging Sep 9, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2019
@sbueringer sbueringer changed the title Add release process for staging Add release process for staging images Sep 9, 2019
@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2019
@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit e783aa8 into kubernetes-sigs:master Sep 10, 2019
@sbueringer sbueringer deleted the pr-release-process branch September 10, 2019 04:17
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
* Re-sync controller implementation with CAPA, Fix cloud config indent bug, also copy addons to examples output folder, Re-sync makefile

* fixup

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants